On 16/08/2022 15:43, Potthuri, Sai Krishna wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: Tuesday, August 16, 2022 1:29 PM >> To: Potthuri, Sai Krishna <sai.krishna.potthuri@xxxxxxx>; Rob Herring >> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski >> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Michal Simek >> <michal.simek@xxxxxxxxxx>; Borislav Petkov <bp@xxxxxxxxx>; Mauro >> Carvalho Chehab <mchehab@xxxxxxxxxx>; Tony Luck <tony.luck@xxxxxxxxx>; >> James Morse <james.morse@xxxxxxx>; Robert Richter <rric@xxxxxxxxxx> >> Cc: devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- >> kernel@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx; >> saikrishna12468@xxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx>; Shubhrajyoti >> Datta <shubhrajyoti.datta@xxxxxxxxxx> >> Subject: Re: [PATCH 1/2] dt-bindings: edac: Add bindings for Xilinx ZynqMP >> OCM >> >> On 16/08/2022 10:32, Sai Krishna Potthuri wrote: >>> From: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx> >>> >>> Add bindings for Xilinx ZynqMP OCM controller. >>> >>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx> >>> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@xxxxxxx> >>> --- >>> .../bindings/edac/xlnx,zynqmp-ocmc.yaml | 41 +++++++++++++++++++ >>> 1 file changed, 41 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/edac/xlnx,zynqmp-ocmc.yaml >>> >>> diff --git >>> a/Documentation/devicetree/bindings/edac/xlnx,zynqmp-ocmc.yaml >>> b/Documentation/devicetree/bindings/edac/xlnx,zynqmp-ocmc.yaml >>> new file mode 100644 >>> index 000000000000..9bcecaccade2 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/edac/xlnx,zynqmp-ocmc.yaml >>> @@ -0,0 +1,41 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/edac/xlnx,zynqmp-ocmc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Xilinx Zynqmp OCM EDAC driver >> >> s/EDAC driver// >> Is it a memory controller? > This driver is about Error Detection and Correction feature for OCM (On Chip > Memory) controller which supports ECC functionality. I am not talking about driver. What is the hardware exactly? On Chip Memory Controller sounds like Memory Controller, so use this instead of EDAC. Best regards, Krzysztof
