On 16/08/2022 13:28, George Mois wrote: > ADXL312 and ADXL314 are small, thin, low power, 3-axis accelerometers > with high resolution (13-bit) measurement up to +/-12 g and +/- 200 g > respectively. > Thank you for your patch. There is something to discuss/improve. > > static const struct spi_device_id adxl313_spi_id[] = { > - { "adxl313" }, > + { "adxl312", ADXL312 }, > + { "adxl313", ADXL313 }, > + { "adxl314", ADXL314 }, > { } > }; > > MODULE_DEVICE_TABLE(spi, adxl313_spi_id); > > static const struct of_device_id adxl313_of_match[] = { > + { .compatible = "adi,adxl312" }, > { .compatible = "adi,adxl313" }, > + { .compatible = "adi,adxl314" }, You miss here driver data. I don't remember which driver matching takes precedence (especially in various cases like DT platforms with device instantiated by MFD), but for consistency I think both device id tables should have same driver data. Best regards, Krzysztof