On Sun, 2022-08-14 at 12:35 -0600, Rob Herring wrote: > On Sun, 14 Aug 2022 15:43:38 +0800, Liu Ying wrote: > > Freescale i.MX8qxp pixel link MSI bus is a simple memory-mapped > > bus. > > It is used to access peripherals in i.MX8qm/qxp imaging, LVDS, MIPI > > DSI and HDMI TX subsystems, like I2C controller, PWM controller, > > MIPI DSI controller and Control and Status Registers (CSR) module. > > > > Reference simple-pm-bus bindings and add Freescale i.MX8qxp pixel > > link MSI bus specific bindings. > > > > Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > > --- > > v3->v4: > > * Add child nodes in the example MSI bus node of the MSI bus dt- > > binding. (Krzysztof) > > > > v2->v3: > > * Add a pattern property to allow child nodes. (Rob) > > > > v1->v2: > > Address Krzysztof's comments: > > * Add a select to explicitly select the MSI bus dt-binding. > > * List 'simple-pm-bus' explicitly as one item of compatible > > strings. > > * Require compatible and reg properties. > > * Put reg property just after compatible property in example. > > > > .../bus/fsl,imx8qxp-pixel-link-msi-bus.yaml | 232 > > ++++++++++++++++++ > > 1 file changed, 232 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi- > > bus.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi- > bus.example.dtb:0:0: /example-0/bus@56200000/syscon@56221000: failed > to match any schema with compatible: ['fsl,imx8qxp-mipi-lvds-csr', > 'syscon', 'simple-mfd'] > Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi- > bus.example.dtb:0:0: /example-0/bus@56200000/syscon@56221000/pxl2dpi: > failed to match any schema with compatible: ['fsl,imx8qxp-pxl2dpi'] > Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi- > bus.example.dtb:0:0: /example-0/bus@56200000/syscon@56221000/ldb: > failed to match any schema with compatible: ['fsl,imx8qxp-ldb'] I sent this a bit earlier than v6.0-rc1. Now, v6.0-rc1 is out and there is no error if the base is v6.0-rc1. > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a > patch > series is generally the most recent rc1. Yes, there are dependencies if the base is v5.19-rc1. > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up > to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Do I need to re-submit? Or, you may run "make DT_CHECKER_FLAGS=-m dt_binding_check" upon v6.0-rc1? Regards, Liu Ying
