On Tue, 9 Aug 2022 11:40:55 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Tue, Aug 9, 2022 at 11:39 AM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: > > ... > > > You may rather switch to devm_clk_get_enabled() and drop this. > > While doing this I would recommend to split the regulator case and clock case. > Hi Andy, I read this and wasn't quite sure what you meant. Do you mean splitting it into multiple patches? If so I think that is probably taking "one thing one patch" a step too far. I wouldn't object it if were presented as separate patches, but I'm not sure I'd bother splitting them. Definitely good to switch to devm_clk_get_enabled() now that's available. There is another go at adding devm_regulator_enable() under review at the moment, but we can tidy that up as a follow on patch (along with the 100s of other cases in IIO!) Jonathan
