On 11/08/2022 16:41, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
>
> Add bindings for the Richtek RT9471 I2C controlled battery charger.
>
Thank you for your patch. There is something to discuss/improve.
> +properties:
> + compatible:
> + const: richtek,rt9471
> +
> + reg:
> + maxItems: 1
> +
> + ceb-gpios:
> + maxItems: 1
This looks not standard, so please provide a description.
> +
> + wakeup-source: true
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 1
Why a charger driver is a interrupt-controller?
> +
> + usb-otg-vbus-regulator:
> + type: object
> + unevaluatedProperties: false
> + $ref: /schemas/regulator/regulator.yaml#
> +
> +required:
> + - compatible
> + - reg
> + - wakeup-source
> + - interrupts
> + - interrupt-controller
> + - "#interrupt-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + charger@53 {
> + compatible = "richtek,rt9471";
> + reg = <0x53>;
> + ceb-gpios = <&gpio26 1 0>;
Isn't the last value a GPIO flag? If yes, use appropriate define.
Best regards,
Krzysztof
