Hi Krzysztof, On Thu, Aug 11, 2022 at 11:50:05AM +0300, Krzysztof Kozlowski wrote: > On 11/08/2022 11:44, Markus Schneider-Pargmann wrote: > > From: Fabien Parent <fparent@xxxxxxxxxxxx> > > > > Add the clock bindings for the MediaTek MT8365 SoC. > > > > Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx> > > --- > > .../bindings/clock/mediatek,mt8365-clock.yaml | 42 ++ > > .../clock/mediatek,mt8365-sys-clock.yaml | 47 +++ > > .../dt-bindings/clock/mediatek,mt8365-clk.h | 374 ++++++++++++++++++ > > 3 files changed, 463 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml > > create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml > > create mode 100644 include/dt-bindings/clock/mediatek,mt8365-clk.h > > > > diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml > > new file mode 100644 > > index 000000000000..31cd248e772b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml > > @@ -0,0 +1,42 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/clock/mediatek,mt8365-clock.yaml#"; > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > > No quotes needed in both lines. > > > + > > +title: MediaTek Functional Clock Controller for MT8365 > > + > > +maintainers: > > + - Fabien Parent <fparent@xxxxxxxxxxxx> > > Are you sure this is correct and working email? Let's try not to add > non-existing emails to Git maintainers. It's a bit of pain to fix it > later. :/ thank you, good point. I will fix everything you mentioned here and above and below for v4. Best, Markus
