On 10/08/2022 16:30, Shenwei Wang wrote: > Add binding document for the imx scu gpio driver. > > Signed-off-by: Shenwei Wang <shenwei.wang@xxxxxxx> > --- > .../bindings/gpio/fsl,imx-sc-gpio.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml > new file mode 100644 > index 000000000000..66abff316c0c > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/fsl,imx-sc-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: GPIO driver over IMX SCU firmware API > + > +maintainers: > + - Shenwei Wang <shenwei.wang@xxxxxxx> > + > +description: | > + This module provides the standard interface to control the > + resource pins in SCU domain on i.MX8 platforms. > + > +properties: > + compatible: > + enum: > + - fsl,imx8qxp-sc-gpio > + - fsl,imx-scu-gpio This is too generic compatible and it even conflicts with the above... Your driver binds to both without driver data which is even more confusing. Make the compatible specific for one, given SoC. Best regards, Krzysztof
