On 05/08/2022 16:57, Marijn Suijten wrote:
> This PMIC is commonly used on boards with an SM6125 SoC and looks very
> similar in layout to the PM6150.
>
> Downstream declares more nodes to be available, but these have been
> omitted from this patch: the pwm/lpg block is unused on my reference
> device making it impossible to test/validate, and the spmi-clkdiv does
> not have a single device-tree binding using this driver yet, hence
> inclusion is better postponed until ie. audio which uses these clocks is
> brought up.
>
Thank you for your patch. There is something to discuss/improve.
> +
> + xo-therm@4c {
> + reg = <ADC5_XO_THERM_100K_PU>;
> + qcom,pre-scaling = <1 1>;
> + qcom,hw-settle-time = <200>;
> + qcom,ratiometric;
> + };
> + };
> +
> + pm6125_adc_tm: adc-tm@3500 {
Generic node names, so either this is adc or thermal-sensor. Looks like
thermal-sensor.
> + compatible = "qcom,spmi-adc-tm5";
> + reg = <0x3500>;
> + interrupts = <0x0 0x35 0x0 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #thermal-sensor-cells = <1>;
> + status = "disabled";
> + };
> +
> + pm6125_rtc: rtc@6000 {
> + compatible = "qcom,pm8941-rtc";
> + reg = <0x6000>, <0x6100>;
> + reg-names = "rtc", "alarm";
> + interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
> + status = "disabled";
> + };
> +
> + pm6125_gpio: gpios@c000 {
s/gpios/gpio/
> + compatible = "qcom,pm6125-gpio", "qcom,spmi-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + gpio-ranges = <&pm6125_gpio 0 0 9>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> +
> + pmic@1 {
> + compatible = "qcom,pm6125", "qcom,spmi-pmic";
> + reg = <0x1 SPMI_USID>;
> + };
> +};
Best regards,
Krzysztof
