On 05/08/2022 13:58, Corey Minyard wrote: > On Thu, Aug 04, 2022 at 09:18:00PM +0300, Tomer Maimon wrote: >> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible >> string becuase NPCM845 and NPCM750 BMCs are using identical KCS modules. >> >> Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> >> --- >> Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt >> index cbc10a68ddef..4fda76e63396 100644 >> --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt >> +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt >> @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host. >> Required properties: >> - compatible : should be one of >> "nuvoton,npcm750-kcs-bmc" >> - "nuvoton,npcm845-kcs-bmc" >> + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc" > > This is just wrong. The compatible is supposed to identify the device, > not the board the device is on. I think compatible here should be > "npcm7xx-kcs-bmc", and just use that everywhere. It's fine if that is No, because you propose to use wildcards as compatible which is not correct. Compatibles must be specific. Best regards, Krzysztof
