Hi Ben, I love your patch! Yet something to improve: [auto build test ERROR on thierry-reding-pwm/for-next] [also build test ERROR on linus/master v5.19 next-20220805] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ben-Dooks/dt-bindings-pwm-Document-Synopsys-DesignWare-snps-pwm-dw-apb-timers-pwm2/20220806-015142 base: https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git for-next config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220807/202208071526.YxCqCuJZ-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/3bd100d711908b7d16a2c4793b4f5b597acb8d7f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Ben-Dooks/dt-bindings-pwm-Document-Synopsys-DesignWare-snps-pwm-dw-apb-timers-pwm2/20220806-015142 git checkout 3bd100d711908b7d16a2c4793b4f5b597acb8d7f # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/pwm/pwm-dwc.c:321:1: warning: data definition has no type or storage class 321 | module_pci_driver(dwc_pwm_driver); | ^~~~~~~~~~~~~~~~~ >> drivers/pwm/pwm-dwc.c:321:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int] drivers/pwm/pwm-dwc.c:321:1: warning: parameter names (without types) in function declaration drivers/pwm/pwm-dwc.c:311:26: warning: 'dwc_pwm_driver' defined but not used [-Wunused-variable] 311 | static struct pci_driver dwc_pwm_driver = { | ^~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +321 drivers/pwm/pwm-dwc.c 1ed2b3fca64516 Jarkko Nikula 2020-10-02 320 1ed2b3fca64516 Jarkko Nikula 2020-10-02 @321 module_pci_driver(dwc_pwm_driver); 1ed2b3fca64516 Jarkko Nikula 2020-10-02 322 -- 0-DAY CI Kernel Test Service https://01.org/lkp
