On Thu, Aug 04, 2022 at 05:09:59PM +0200, Johan Hovold wrote: > Add a wakeup-source property to the binding to describe whether the > wakeup interrupts can wake the system from suspend. > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> So this is based on the fact that Qcom glue wrapper is supplying the wakeup interrupts. But isn't it possible that on other platform, the DWC IP can supply wakeup interrupts? In the driver, the wakeup-source parsing has been moved to the Qcom glue driver. But this contradicts with the binding. Thanks, Mani > --- > > Changes in v2 > - disallow 'wakeup-source' in child node (Krzysztof) > > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > index fea3e7092ace..d5959bdea63e 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > @@ -108,12 +108,17 @@ properties: > HS/FS/LS modes are supported. > type: boolean > > + wakeup-source: true > + > # Required child node: > > patternProperties: > "^usb@[0-9a-f]+$": > $ref: snps,dwc3.yaml# > > + properties: > + wakeup-source: false > + > required: > - compatible > - reg > -- > 2.35.1 > -- மணிவண்ணன் சதாசிவம்
