Hi Johan, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on linus/master next-20220804] [cannot apply to robh/for-next v5.19] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Johan-Hovold/usb-dwc3-qcom-fix-wakeup-implementation/20220804-231122 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: arc-randconfig-r002-20220804 (https://download.01.org/0day-ci/archive/20220805/202208050544.ijUhoUyB-lkp@xxxxxxxxx/config) compiler: arc-elf-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f3778ca026b16474e49c5e0188a0eb91d73eef2f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Johan-Hovold/usb-dwc3-qcom-fix-wakeup-implementation/20220804-231122 git checkout f3778ca026b16474e49c5e0188a0eb91d73eef2f # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/usb/dwc3/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/usb/dwc3/dwc3-qcom.c: In function 'dwc3_qcom_read_usb2_speed': >> drivers/usb/dwc3/dwc3-qcom.c:313:25: warning: variable 'hcd' set but not used [-Wunused-but-set-variable] 313 | struct usb_hcd *hcd; | ^~~ vim +/hcd +313 drivers/usb/dwc3/dwc3-qcom.c 308 309 static enum usb_device_speed dwc3_qcom_read_usb2_speed(struct dwc3_qcom *qcom) 310 { 311 struct dwc3 *dwc = platform_get_drvdata(qcom->dwc3); 312 struct usb_device *udev; > 313 struct usb_hcd *hcd; 314 315 /* 316 * FIXME: Fix this layering violation. 317 */ 318 hcd = platform_get_drvdata(dwc->xhci); 319 320 /* 321 * It is possible to query the speed of all children of 322 * USB2.0 root hub via usb_hub_for_each_child(). DWC3 code 323 * currently supports only 1 port per controller. So 324 * this is sufficient. 325 */ 326 #ifdef CONFIG_USB 327 udev = usb_hub_find_child(hcd->self.root_hub, 1); 328 #else 329 udev = NULL; 330 #endif 331 if (!udev) 332 return USB_SPEED_UNKNOWN; 333 334 return udev->speed; 335 } 336 -- 0-DAY CI Kernel Test Service https://01.org/lkp
