Re: [PATCH v4 2/3] iio: add MEMSensing MSA311 3-axis accelerometer driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 4, 2022 at 8:17 PM Dmitry Rokosov <DDRokosov@xxxxxxxxxxxxxx> wrote:
> On Wed, Aug 03, 2022 at 07:16:13PM +0000, Dmitry Rokosov wrote:
> > On Wed, Aug 03, 2022 at 07:49:33PM +0200, Andy Shevchenko wrote:
> > > On Wed, Aug 3, 2022 at 3:11 PM Dmitry Rokosov <DDRokosov@xxxxxxxxxxxxxx> wrote:

Please, remove unneeded context when replying!

...

> > > > +               dev_err(dev, "cannot %s register %u from debugfs (%d)\n",
> > > > +                       readval ? "read" : "write", reg, err);
> > >
> > > You may consider taking [1] as a precursor here and use str_read_write().
> > >
> > > [1]: https://lore.kernel.org/linux-i2c/20220703154232.55549-1-andriy.shevchenko@xxxxxxxxxxxxxxx/
> >
> > Oh, really... Thank you for suggestion!
>
> I have taken it closer, and it's really helpful and nice, but looks like
> it's not merged to linux-next.
> Please advise how I can use it in the driver. Should I provide
> "Depends-On:" tag as I did for my HZ units patchset?

No, just take that patch into your series.

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux