Re: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

On Thu, 4 Aug 2022 at 18:01, Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote:
>
> Dear Tomer,
>
>
> Am 04.08.22 um 16:55 schrieb Tomer Maimon:
> > Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
> > string.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> > index cbc10a68ddef..4fda76e63396 100644
> > --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> > +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> > @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
> >   Required properties:
> >   - compatible : should be one of
> >       "nuvoton,npcm750-kcs-bmc"
> > -    "nuvoton,npcm845-kcs-bmc"
> > +    "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
>
> Isn’t the added string exactly the same as the one below the compatible
> line?
it is not the same, it describes a fallback to NPCM7XX KCS Since
NPCM8XX KCS and NPCM7XX KCS modules are similar.
>
> >   - interrupts : interrupt generated by the controller
> >   - kcs_chan : The KCS channel number in the controller
>
>
> Kind regards,
>
> Paul

Best regards,

Tomer




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux