On 04/08/2022 15:09, bchihi@xxxxxxxxxxxx wrote: > From: Alexandre Bailon <abailon@xxxxxxxxxxxx> > > This patch adds dt-binding documents for mt8192 and mt8195 thermal controllers. Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Signed-off-by: Alexandre Bailon <abailon@xxxxxxxxxxxx> > Signed-off-by: Balsam CHIHI <bchihi@xxxxxxxxxxxx> Please rebase your patches on recent Linux kernel (or next). > --- > .../thermal/mediatek,lvts-thermal.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > new file mode 100644 > index 000000000000..53c44a73f3a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek SoC LVTS thermal controller > + > +maintainers: > + - Yu-Chia Chang <ethan.chang@xxxxxxxxxxxx> > + - Ben Tseng <ben.tseng@xxxxxxxxxxxx> > + Any reason why not referencing thermal-sensor.yaml? > +properties: > + compatible: > + enum: > + - mediatek,mt8192-lvts-ap > + - mediatek,mt8192-lvts-mcu > + - mediatek,mt8195-lvts-ap > + - mediatek,mt8195-lvts-mcu > + > + "#thermal-sensor-cells": > + const: 1 > + > + reg: > + maxItems: 2 You need to describe the items (like nvmem-cells). > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + items: > + - description: SW reset HW AP/MCU domain to clean temporary data on HW initialization/resume. > + > + nvmem-cells: > + items: > + - description: LVTS calibration data 1 for thermal sensors > + - description: LVTS calibration data 2 for thermal sensors > + > + nvmem-cell-names: > + items: > + - const: lvts_calib_data1 > + - const: lvts_calib_data2 > + > +required: > + - compatible > + - '#thermal-sensor-cells' > + - reg > + - interrupts > + - clocks > + - resets > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/thermal/thermal.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/mt8195-clk.h> > + #include <dt-bindings/reset/mt8195-resets.h> > + > + lvtsmcu: thermal-sensor@11278000 { Mixed-up indentation. Best regards, Krzysztof
