On Wed, Aug 03, 2022 at 09:51:00AM +0200, Krzysztof Kozlowski wrote: > On 03/08/2022 09:31, Johan Hovold wrote: > > On Tue, Aug 02, 2022 at 11:17:22AM -0600, Rob Herring wrote: > >> On Tue, Aug 2, 2022 at 9:14 AM Johan Hovold <johan+linaro@xxxxxxxxxx> wrote: > > > >>> It should also not be used to > >>> work around Linux driver implementation issues such as how to coordinate > >>> the glue and core dwc3 drivers. > >>> > >>> For the Qualcomm dwc3 controllers, it is the glue device that manages > >>> the wakeup interrupts, which may or may not be able to wake the system > >>> up from system suspend. > >> > >> While the reasoning to add this may have been for QCom, having this > >> property for other users makes sense. On some platforms, 'snps,dwc3' > >> is the only node (i.e. there's no wrapper node). So I don't think this > >> should be reverted. > > > > Fair enough. Let's keep it in the core child node then where we can > > still retrieve from the glue parent directly. > > > > (I assume you're not suggesting also adding 'wakeup-source' to the qcom > > glue node, which is where the actual wakeup interrupts live.) > > > > The glue and core parts needs to work in concert even if the current > > implementation tends to make that harder than it should be. > > I think it can still exist in the glue node (so your next patch), > because as you said this is the place with wakeup interrupt, so it looks > like correct hardware description. In the next patch you would need to > disallow it for the DWC node. Ok, will do. Thanks. Johan
