On Tue, 2022-08-02 at 10:58 +0200, Krzysztof Kozlowski wrote:
> On 29/07/2022 08:31, Tinghan Shen wrote:
> > The System Control Processor System (SCPSYS) has several power
> > management related tasks in the system. Add the bindings for it.
> >
> > Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx>
>
> Thank you for your patch. There is something to discuss/improve.
>
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/mt8195-clk.h>
> > + #include <dt-bindings/power/mt8195-power.h>
> > +
> > + syscon@10006000 {
> > + compatible = "mediatek,mt8195-scpsys", "syscon", "simple-mfd";
> > + reg = <0x10006000 0x100>;
> > +
> > + spm: power-controller {
> > + compatible = "mediatek,mt8195-power-controller";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + #power-domain-cells = <1>;
> > +
> > + /* sample of power domain nodes */
> > + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY {
> > + reg = <MT8195_POWER_DOMAIN_PCIE_PHY>;
>
> Wrong indentation.
I missed these lines...
I'll update in the next version.
Best regards,
TingHna
