Re: [PATCH v3 00/13] PM6125 regulator support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/08/2022 01:37, Iskren Chernev wrote:
This patch series adds SPMI and SMD regulator support for the PM6125 found on
SM4250/SM6115 SoCs from QCom.

This code has been tested on:
* OnePlus Nord N100 (oneplus,billie2, SoC sm4250)
* Redmi 9T (redmi,lemon, SoC sm6115)

The main source used for this change is qpnp pm6125 support patch from caf [1]:

[1]: https://source.codeaurora.org/quic/la/kernel/msm-5.4/commit/?h=kernel.lnx.5.4.r1-rel&id=d1220daeffaa440ffff0a8c47322eb0033bf54f5

v2: https://lkml.org/lkml/2022/7/26/885
v1: https://lkml.org/lkml/2021/8/28/144

Changes from v2:
- split spmi new regulator support in 2 patches
- FTS and LDOs now have set_load and set_pull_down ops
- add better commit messages on spmi patches
- fix sob header order
- fix tested device info (Redmi 9T, NOT Xiaomi 9T)
- improve formatting in spmi binding docs
- sort alphabetically in smd binding docs
- sort alphabetically spmi pmics
- sort alphabetically smd pmics
Changes from v1:
- add dt-bindings
- split SPMI patch into new reg types and the new PMIC
- add correct supply mapping

Iskren Chernev (13):
   dt-bindings: regulator: qcom_spmi: Improve formatting of if-then
     blocks
   dt-bindings: regulator: qcom_spmi: Document PM6125 PMIC
   dt-bindings: regulator: qcom_smd: Sort compatibles alphabetically
   dt-bindings: regulator: qcom_smd: Document PM6125 PMIC
   regulator: qcom_spmi: Add support for new regulator types
   regulator: qcom_spmi: Add support for HFSMPS regulator type
   regulator: qcom_spmi: Sort pmics alphabetically (part 1)
   regulator: qcom_spmi: Sort pmics alphabetically (part 2)
   regulator: qcom_spmi: Add PM6125 PMIC support
   regulator: qcom_smd: Sort pmics alphabetically (part 1)
   regulator: qcom_smd: Sort pmics alphabetically (part 2)
   regulator: qcom_smd: Sort pmics alphabetically (part 3)

What is the reason for these part1/2 and part1/2/3 splits? I think you can collapse them into two respective patches, one sorting of spmi, another one sorting the smd regulators

   regulator: qcom_smd: Add PM6125 regulators support

  .../regulator/qcom,smd-rpm-regulator.yaml     |  26 +-
  .../regulator/qcom,spmi-regulator.yaml        |  32 ++
  drivers/regulator/qcom_smd-regulator.c        | 400 ++++++++++--------
  drivers/regulator/qcom_spmi-regulator.c       | 383 ++++++++++++-----
  4 files changed, 556 insertions(+), 285 deletions(-)



--
With best wishes
Dmitry



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux