On Fri, Jul 29, 2022 at 1:06 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote: > On 27.07.22 19:39, Andy Shevchenko wrote: > > On Wed, Jul 27, 2022 at 12:01 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote: ... > Instead I end up at a longer comment again. It's fine! > Though this also offers the chance to add some additional information > where the values were taken from. > > Is it appropriate to include this to kernel doc? Generally I'm unsure on > kernel doc but I guess yes... I'm unsure if it's appropriate for static (integer) arrays, you may run kernel doc script yourself and check man, html and pdf formats to see if it's rendered correctly. ... > > Again, you are the author and my point is just to make you look at > > this from different angles. If you see no better way, go with the > > current approach, but just spend a half an hour and perhaps we may > > have a cleaner solution? > > Indeed, to my own surprise I found a solution with the 2D array: It looks better! ... > dev_info(dev, "detected %s %s\n", > yas5xx->chip_info->product_name, > yas5xx->chip_info->version_name[yas5xx->version]); Very good! -- With Best Regards, Andy Shevchenko
