On Fri, Jul 29, 2022 at 5:19 PM Balsam CHIHI <bchihi@xxxxxxxxxxxx> wrote: > > On Thu, Jul 28, 2022 at 10:53 AM Daniel Lezcano > <daniel.lezcano@xxxxxxxxxx> wrote: > > > > > > Hi Balsam, > > > > On 26/07/2022 15:55, Balsam CHIHI wrote: > > > Add Mediatek proprietary folder to upstream more thermal zone and cooler > > > drivers. Relocate the original thermal controller driver to it and rename > > > as soc_temp.c to show its purpose more clearly. > > > > I realize the Kconfig, Makefiles format are not consistent across the > > boards. Before I fix this, you can comply to the format: > > > > drivers/thermal/Kconfig: > > > > menu "Mediatek thermal drivers" > > depends on ARCH_MEDIATEK || COMPILE_TEST > > source "drivers/thermal/mediatek/Kconfig" > > endmenu > > > > drivers/thermal/Makefile: > > > > -obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o > > +obj-y += mediatek > > > > drivers/thermal/mediatek/Kconfig: > > > > config MTK_SOC_THERMAL > > tristate "Temperature sensor driver for MediaTek SoCs" > > depends on HAS_IOMEM > > depends on NVMEM > > depends on RESET_CONTROLLER > > help > > Enable this option if you want to get SoC temperature > > information for MediaTek platforms. This driver > > configures thermal controllers to collect temperature > > via AUXADC interface. > > > > drivers/thermal/mediatek/Makefile: > > > > obj-$(MTK_SOC_THERMAL) += soc_temp.o > > > > However, rename 'soc_temp' to something more SoC explicit, eg. > > mtxxx_thermal.c > > > > Thanks > > > > -- Daniel > > Hello Daniel, > > Thank you for the feedback. > Changes have been made as you suggested. > Resubmitting seen. *soon. > > Best regards. > Balsam.
