Hi, please see a minor comment inline below: On Tue, Jul 26, 2022 at 03:24:06PM +0300, Arınç ÜNAL wrote: > [...] > - CPU-Ports need a phy-mode property: > - Allowed values on mt7530 and mt7621: > - - "rgmii" > - - "trgmii" > - On mt7531: > - - "1000base-x" > - - "2500base-x" > - - "rgmii" > - - "sgmii" > + There are two versions of MT7530. MT7621AT, MT7621DAT, MT7621ST and MT7623AI There are two version of MT7530 **supported by this driver**..... (MT7620 also contains MT7530, switch registers are directly mapped into SoC's memory map rather than using MDIO like on MT7621 and standalone variants, and it got FastEthernet PHYs for Port 0-4)
