On 28/07/2022 15:50, Sam Ravnborg wrote: > Hi Krzysztof > On Thu, Jul 28, 2022 at 02:17:29PM +0200, Krzysztof Kozlowski wrote: >> On 28/07/2022 04:35, Molly Sophia wrote: >>> Novatek NT35596s is a generic DSI IC that drives command and video mode >>> panels. Add the driver for it. Currently add support for the LCD panel >>> from JDI connected with this IC, as found on Xiaomi Mi Mix2s phones. >>> >>> Changes in v4: >>> - No change. >>> >>> Changes in v3: >>> - Embed the support into existing driver (panel-novatek-nt36672a), as >>> these two IC are similar with different initialization commands. >>> >> >> This does not go to commit msg (---). > It depends... > > In the drm sub-system the general rule is if someone cares to write it, > then it deserves to be added to the commit message. > So for drm patches it is perfectly fine to have the history part > included in the commit message. > > These sub-system differences does not makes it easier - I know. OK, but I find it weird to store "No change" in commit log :) Best regards, Krzysztof
