On 28/07/2022 13:16, Shinjo Park wrote:
> Use the same USB definition as qcom-apq8064.dtsi, tested on Casio GzOne.
>
> Signed-off-by: Shinjo Park <peremen@xxxxxxxxx>
> Reviewed-by: David Heidelberg <david@xxxxxxx>
Thank you for your patch. There is something to discuss/improve.
Similar problems as with previous patch - thread your patches and how
did you get review?
> ---
> arch/arm/boot/dts/qcom-msm8960.dtsi | 32 +++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index 991eb1948..a32073d61 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -4,6 +4,7 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/qcom,gcc-msm8960.h>
> #include <dt-bindings/clock/qcom,lcc-msm8960.h>
> +#include <dt-bindings/reset/qcom,gcc-msm8960.h>
> #include <dt-bindings/mfd/qcom-rpm.h>
> #include <dt-bindings/soc/qcom,gsbi.h>
>
> @@ -201,6 +202,37 @@ regulators {
> };
> };
>
> + usb1: usb@12500000 {
> + compatible = "qcom,ci-hdrc";
> + reg = <0x12500000 0x200>,
> + <0x12500200 0x200>;
> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>;
> + clock-names = "core", "iface";
> + assigned-clocks = <&gcc USB_HS1_XCVR_CLK>;
> + assigned-clock-rates = <60000000>;
> + resets = <&gcc USB_HS1_RESET>;
> + reset-names = "core";
> + phy_type = "ulpi";
> + ahb-burst-config = <0>;
> + phys = <&usb_hs1_phy>;
> + phy-names = "usb-phy";
> + status = "disabled";
status is the last property.
> + #reset-cells = <1>;
Best regards,
Krzysztof
