On 28/07/2022 13:29, AngeloGioacchino Del Regno wrote: > Il 26/07/22 12:37, Sen Chu ha scritto: >> Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform. >> >> Signed-off-by: Sen Chu <sen.chu@xxxxxxxxxxxx> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml >> index 2445c5e0b0ef..05801e0199f9 100644 >> --- a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml >> +++ b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml >> @@ -20,6 +20,7 @@ properties: >> compatible: >> enum: >> - mediatek,mt6873-spmi >> + - mediatek,mt8188-spmi > > I think that you'll be adding a SPMI node that will have: > > compatible = "mediatek,mt8188-spmi", "mediatek,mt8195-spmi"; > > Which means that this is actually wrong, so, please fix it by > adding items... I wished bindings were not coming along but with DTS so we can check if submitter understands what he/she/they are coding... I also wished bindings in schema were used for testing their own DTBS without sending. Ehh.... :( Best regards, Krzysztof
