Re: [PATCH v2 1/2] dt-bindings: pinctrl: add support for MediaTek mt8188

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 27 Jul 2022 18:21:39 +0800, Hui Liu wrote:
> From: "Hui.Liu" <hui.liu@xxxxxxxxxxxx>
> 
> Add pinctrl function header file and binding document for mt8188.
> 
> Signed-off-by: Hui.Liu <hui.liu@xxxxxxxxxxxx>
> ---
>  .../pinctrl/mediatek,mt8188-pinctrl.yaml      |  238 +++
>  .../pinctrl/mediatek,mt8188-pinfunc.h         | 1280 +++++++++++++++++
>  2 files changed, 1518 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
>  create mode 100644 include/dt-bindings/pinctrl/mediatek,mt8188-pinfunc.h
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml: $id: relative path/filename doesn't match actual path or filename
	expected: http://devicetree.org/schemas/pinctrl/mediatek,mt8188-pinctrl.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: spi0-pins:pins-spi:bias-pull-up: More than one condition true in oneOf schema:
	{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {},
	           {'items': [{'items': [{'enum': [200,
	                                           201,
	                                           202,
	                                           203,
	                                           204,
	                                           205,
	                                           206,
	                                           207]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {},
	           {'items': [{'items': [{'enum': [1000,
	                                           1500,
	                                           2000,
	                                           3000,
	                                           4000,
	                                           5000,
	                                           10000,
	                                           75000]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {}]}
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: spi0-pins:pins-spi-mi:bias-pull-down: More than one condition true in oneOf schema:
	{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {},
	           {'items': [{'items': [{'enum': [200,
	                                           201,
	                                           202,
	                                           203,
	                                           204,
	                                           205,
	                                           206,
	                                           207]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {},
	           {'items': [{'items': [{'enum': [75000, 5000]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {}]}
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: i2c0-pins:pins:bias-pull-down: More than one condition true in oneOf schema:
	{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {},
	           {'items': [{'items': [{'enum': [200,
	                                           201,
	                                           202,
	                                           203,
	                                           204,
	                                           205,
	                                           206,
	                                           207]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {},
	           {'items': [{'items': [{'enum': [75000, 5000]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {}]}
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: i2c1-pins:pins:bias-pull-up: More than one condition true in oneOf schema:
	{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {},
	           {'items': [{'items': [{'enum': [200,
	                                           201,
	                                           202,
	                                           203,
	                                           204,
	                                           205,
	                                           206,
	                                           207]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {},
	           {'items': [{'items': [{'enum': [1000,
	                                           1500,
	                                           2000,
	                                           3000,
	                                           4000,
	                                           5000,
	                                           10000,
	                                           75000]}],
	                       'maxItems': 1,
	                       'minItems': 1,
	                       'type': 'array'}],
	            'maxItems': 1,
	            'minItems': 1,
	            'type': 'array'},
	           {}]}
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux