Hi Jiucheng, I love your patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on arm64/for-next/core clk/clk-next soc/for-next linus/master v5.19-rc8 next-20220726] [cannot apply to xilinx-xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jiucheng-Xu/perf-amlogic-Add-support-for-Amlogic-meson-G12-SoC-DDR-PMU-driver/20220727-070511 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220727/202207272141.rn8Zx4Az-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/be1236818a5d0ad61b0f9ecbe5f03b9e63f99365 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jiucheng-Xu/perf-amlogic-Add-support-for-Amlogic-meson-G12-SoC-DDR-PMU-driver/20220727-070511 git checkout be1236818a5d0ad61b0f9ecbe5f03b9e63f99365 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/perf/amlogic/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/perf/amlogic/aml_ddr_pmu_core.c: In function 'event_show_unit': >> drivers/perf/amlogic/aml_ddr_pmu_core.c:208:38: warning: variable 'pmu_attr' set but not used [-Wunused-but-set-variable] 208 | struct perf_pmu_events_attr *pmu_attr; | ^~~~~~~~ drivers/perf/amlogic/aml_ddr_pmu_core.c: In function 'event_show_scale': drivers/perf/amlogic/aml_ddr_pmu_core.c:218:38: warning: variable 'pmu_attr' set but not used [-Wunused-but-set-variable] 218 | struct perf_pmu_events_attr *pmu_attr; | ^~~~~~~~ vim +/pmu_attr +208 drivers/perf/amlogic/aml_ddr_pmu_core.c 203 204 static ssize_t 205 event_show_unit(struct device *dev, struct device_attribute *attr, 206 char *page) 207 { > 208 struct perf_pmu_events_attr *pmu_attr; 209 210 pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr); 211 return sysfs_emit(page, "MB\n"); 212 } 213 -- 0-DAY CI Kernel Test Service https://01.org/lkp
