On Tue, Jul 26, 2022 at 09:11:31PM +0300, Iskren Chernev wrote:
> Add support for some regulator types that are missing in this driver, all
> belonging to the FTSMPS426 register layout. This is done in preparation
> for adding support for the PM6125 PMIC.
> + .set_mode = spmi_regulator_ftsmps3_set_mode,
> + .get_mode = spmi_regulator_ftsmps426_get_mode,
Why are set and get asymmetric?
> @@ -1473,7 +1557,7 @@ static const struct spmi_regulator_mapping supported_regulators[] = {
> SPMI_VREG(LDO, HT_P600, 0, INF, HFS430, hfs430, ht_p600, 10000),
> SPMI_VREG(LDO, HT_P150, 0, INF, HFS430, hfs430, ht_p150, 10000),
> SPMI_VREG(BUCK, GP_CTL, 0, INF, SMPS, smps, smps, 100000),
> - SPMI_VREG(BUCK, HFS430, 0, INF, HFS430, hfs430, hfs430, 10000),
> + SPMI_VREG(BUCK, HFS430, 0, 3, HFS430, hfs430, hfs430, 10000),
The changelog said we were adding support for new types but this looks
like changing an existing type.
Attachment:
signature.asc
Description: PGP signature
