On Tue, 26 Jul 2022 at 21:11, Iskren Chernev <iskren.chernev@xxxxxxxxx> wrote: > > Add support for pm6125 compatible string and add relevant supplies in QCom SPMI > regulator documentation. > > Signed-off-by: Iskren Chernev <iskren.chernev@xxxxxxxxx> > Signed-off-by: Adam Skladowski <a39.skl@xxxxxxxxx> The order of sign-offs seems incorrect. The sender's signature should be the last one. > --- > .../regulator/qcom,spmi-regulator.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.yaml > index 8b7c4af4b551..d8f18b441484 100644 > --- a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.yaml > @@ -12,6 +12,7 @@ maintainers: > properties: > compatible: > enum: > + - qcom,pm6125-regulators > - qcom,pm660-regulators > - qcom,pm660l-regulators > - qcom,pm8004-regulators > @@ -106,6 +107,24 @@ required: > - compatible > > allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pm6125-regulators > + then: > + properties: > + vdd_l1_l7_l17_l18-supply: true > + vdd_l2_l3_l4-supply: true > + vdd_l5_l15_l19_l20_l21_l22-supply: true > + vdd_l6_l8-supply: true > + vdd_l9_l11-supply: true > + vdd_l10_l13_l14-supply: true > + vdd_l12_l16-supply: true > + vdd_l23_l24-supply: true > + patternProperties: > + "^vdd_s[1-8]-supply$": true Add an empty line please. > - if: > properties: > compatible: > -- > 2.37.1 > -- With best wishes Dmitry