Hi Rob, Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Tuesday, July 26, 2022 1:10 AM > To: Rob Herring <robh@xxxxxxxxxx>; Harini Katakam > <harini.katakam@xxxxxxxxxx> > Cc: nicolas.ferre@xxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; > claudiu.beznea@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; edumazet@xxxxxxxxxx; > pabeni@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > michal.simek@xxxxxxxxxx; harinikatakamlinux@xxxxxxxxx; Katakam, Harini > <harini.katakam@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; > radhey.shyam.pandey@xxxxxxxxxx > Subject: Re: [PATCH v2 1/3] dt-bindings: net: cdns,macb: Add versal > compatible string > > On 25/07/2022 21:33, Rob Herring wrote: > > On Fri, Jul 22, 2022 at 04:33:28PM +0530, Harini Katakam wrote: <snip> > >> > >> - items: > >> - enum: > >> + - cdns,versal-gem # Xilinx Versal > >> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC > >> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC > > > > Uh, how did we start this pattern? The vendor here is Xilinx, not > > Cadence. It should be xlnx,versal-gem instead. I'm not sure how the pattern started but I see that all the early versions of compatible strings added (Xilinx, Atmel, Microchip) has cdns prefix. Links for reference: https://lore.kernel.org/lkml/1432756728-6778-1-git-send-email-nathan.sullivan@xxxxxx/ https://lore.kernel.org/lkml/1432244845-29315-1-git-send-email-nathan.sullivan@xxxxxx/ https://lore.kernel.org/lkml/1430931438-32592-1-git-send-email-harinik@xxxxxxxxxx/ I can switch to xlnx,versal-gem now. Regards, Harini
