On Mon, Jul 25, 2022 at 6:49 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote: > > Il 25/07/22 12:44, Chen-Yu Tsai ha scritto: > > On Thu, Jul 21, 2022 at 10:53 PM AngeloGioacchino Del Regno > > <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote: > >> > >> All machines of the Cherry platform have a working DSP (integrated > >> into the MT8195 SoC), and audio support, some with a different audio > >> codec: specifically, some using Realtek's RT5682I and some RT5682S. > >> > >> Write a configuration for all the audio bits to enable functionality. > > > > I think we're still missing some code for SOF that implements the > > machine_select() callback, plus the firmware has to be fetched from > > the ChromeOS rootfs. > > > > It might make sense to have SOF disabled for now. Removing the adsp > > reference and the overriding dai-link entry from the sound node > > should do the trick. > > > > Uhm... I think that we should either have audio, with DSP, or not have it > at all... the userspace configurations will differ, so we'd end up with > two different confs of which one will get unused and cluttering the ucm2 > conf git. You're right. I haven't even figured out which ones to pull in. > At this point, I think that the most sensible option is to either omit > this commit, or keep audio disabled until the machine_select() callback > gets in... Agreed. ChenYu
