On Fri, Jul 22, 2022 at 02:41:35PM +0300, Tomer Maimon wrote: > Add a compatible string for Nuvoton BMC NPCM845 PSPI. > > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> > --- > Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt > index b98203ca656d..a4e72e52af59 100644 > --- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt > +++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt > @@ -3,7 +3,8 @@ Nuvoton NPCM Peripheral Serial Peripheral Interface(PSPI) controller driver > Nuvoton NPCM7xx SOC support two PSPI channels. > > Required properties: > - - compatible : "nuvoton,npcm750-pspi" for NPCM7XX BMC > + - compatible : "nuvoton,npcm750-pspi" for Poleg NPCM7XX. Who/What is Polog? Board/BMC vendor? If so, that should not be in SoC bindings. > + "nuvoton,npcm845-pspi" for Arbel NPCM8XX. Same for Arbel. To answer your question on fallback, just put: "nuvoton,npcm845-pspi", "nuvoton,npcm750-pspi" for NPCM8XX BMC > - #address-cells : should be 1. see spi-bus.txt > - #size-cells : should be 0. see spi-bus.txt > - specifies physical base address and size of the register. > -- > 2.33.0 > >