Hi Krzysztof, thanks for the review. Will push a v2 fixing those points. Alain On Thu, Jul 21, 2022 at 06:32:18PM +0200, Krzysztof Kozlowski wrote: > On 21/07/2022 17:34, Alain Volmat wrote: > > Add the 5 instances of spi busses supported by the stm32mp131. > > > > Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx> > > --- > > arch/arm/boot/dts/stm32mp131.dtsi | 70 +++++++++++++++++++++++++++++++ > > 1 file changed, 70 insertions(+) > > > > diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi > > index da9e8a6ca663..db3d1b900d5c 100644 > > --- a/arch/arm/boot/dts/stm32mp131.dtsi > > +++ b/arch/arm/boot/dts/stm32mp131.dtsi > > @@ -97,6 +97,34 @@ scmi_shm: scmi-sram@0 { > > }; > > }; > > > > + spi2: spi@4000b000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "st,stm32h7-spi"; > > + reg = <0x4000b000 0x400>; > > Unusual order... rather first compatible then reg. > > Best regards, > Krzysztof