On 22/07/2022 21:45, Sam Ravnborg wrote: > Hi Krzysztof > > On Fri, Jul 22, 2022 at 09:15:39PM +0200, Krzysztof Kozlowski wrote: >> The spi-cpha and spi-cpol properties are device specific and should be >> accepted only if device really needs them. Drop them from common >> spi-peripheral-props.yaml schema, mention in few panel drivers which use >> themi > > "and include instead in the SPI controller bindings." > > I cannot see you do this in the touched bindings. Yep, because you always have two schemas being in play. One is SPI controller and other is the device (SPI slave). > So I cannot see how for example samsung,ld9040.yaml picks up > spi-controller.yaml and thus it no longer knows the spi-cpha and spi-cpol > properties. ld9040 is not spi-controller, but a SPI slave device, AFAIU. It will be therefore a child of some SPI controller, thus the SPI controller schema, which includes spi-controller.yaml, will validate the type of spi-cpha/cpol properties. Best regards, Krzysztof
