Re: [PATCH 1/3] dt-bindings: arm: qcom: stop describing individual boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/07/2022 11:09, Dmitry Baryshkov wrote:
> Describing each compatible board in DT schema seems wrong to me. It
> means that each new board is incompatible by default, until added to the
> DT schema. If any of the vendors for whatever reasons tries to validate
> their new device's DT, they will be stuck with it being incompatible
> with arm/qcom.yaml until the file is expanded to include such devices.
> 
> Rework simple cases by dropping individual board compatible strings and
> replacing them with the empty schema.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/arm/qcom.yaml         | 203 ++++--------------
>  1 file changed, 39 insertions(+), 164 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index fb1d00bcc847..d4d945a43178 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -107,60 +107,39 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> -          - enum:
> -              - qcom,apq8016-sbc
> +          - {}
>            - const: qcom,apq8016
>  

No, this removes documentation of compatibles thus removes part
documenting the ABI.


Best regards,
Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux