On 22/07/2022 13:41, Tomer Maimon wrote: > Add Nuvoton BMC NPCM845 NPCM Peripheral SPI (PSPI) support. > > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> > --- > drivers/spi/spi-npcm-pspi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-npcm-pspi.c b/drivers/spi/spi-npcm-pspi.c > index 1668a347e003..7f2e4d1b0d43 100644 > --- a/drivers/spi/spi-npcm-pspi.c > +++ b/drivers/spi/spi-npcm-pspi.c > @@ -443,6 +443,7 @@ static int npcm_pspi_remove(struct platform_device *pdev) > > static const struct of_device_id npcm_pspi_match[] = { > { .compatible = "nuvoton,npcm750-pspi", .data = NULL }, > + { .compatible = "nuvoton,npcm845-pspi", .data = NULL }, The devices look compatible, so why not reusing 750 compatible and adding more specific upfront only in the bindings instead? Best regards, Krzysztof