On 7/21/22 10:42 AM, Krzysztof Kozlowski wrote: > On 17/07/2022 00:47, Sean Anderson wrote: >> On 7/15/22 7:06 PM, Rob Herring wrote: >>> On Fri, 15 Jul 2022 17:59:10 -0400, Sean Anderson wrote: >>>> This converts the MAC portion of the FMan MAC bindings to yaml. >>>> >>>> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx> >>>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >>>> --- >>>> >>>> Changes in v3: >>>> - Incorporate some minor changes into the first FMan binding commit >>>> >>>> Changes in v2: >>>> - New >>>> >>>> .../bindings/net/fsl,fman-dtsec.yaml | 145 ++++++++++++++++++ >>>> .../devicetree/bindings/net/fsl-fman.txt | 128 +--------------- >>>> 2 files changed, 146 insertions(+), 127 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/net/fsl,fman-dtsec.yaml >>>> >>> >>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/fsl,fman-dtsec.example.dtb: ethernet@e8000: 'phy-connection-type', 'phy-handle' do not match any of the regexes: 'pinctrl-[0-9]+' >>> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/fsl,fman-dtsec.yaml >>> >>> doc reference errors (make refcheckdocs): >> >> What's the correct way to do this? I have '$ref: ethernet-controller.yaml#' >> under allOf, but it doesn't seem to apply. IIRC this doesn't occur for actual dts files. > > You do not allow any other properties than explicitly listed > (additionalProp:false). If you want to apply all properties from other > schema you need to use unevaluated. > > https://elixir.bootlin.com/linux/v5.19-rc7/source/Documentation/devicetree/bindings/writing-bindings.rst#L75 Thanks, I'll fix that. Although I wasn't able to reproduce this error locally. I'm using the following command: CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 make O=build -j12 dt_binding_check DT_SCHEMA_FILES=fsl,fman-dtsec.yaml DT_CHECKER_FLAGS=-m --Sean
