Hi Bryan, On Mon, Jul 18, 2022 at 02:42:13AM +0100, Bryan O'Donoghue wrote: > The yaml and driver we have right now misidentifies the imx577 as the > imx412. > > Looking at similar IMX chips which give their chip identifier via register > 0x0016 we can see: > > drivers/media/i2c/imx258.c:#define IMX258_REG_CHIP_ID 0x0016 > drivers/media/i2c/imx258.c:#define IMX258_CHIP_ID 0x0258 > > drivers/media/i2c/imx319.c:#define IMX319_REG_CHIP_ID 0x0016 > drivers/media/i2c/imx319.c:#define IMX319_CHIP_ID 0x0319 > > drivers/media/i2c/imx355.c:#define IMX355_REG_CHIP_ID 0x0016 > drivers/media/i2c/imx355.c:#define IMX355_CHIP_ID 0x0355 > > Right now imx412.c does: > > drivers/media/i2c/imx412.c:#define IMX412_REG_ID 0x0016 > drivers/media/i2c/imx412.c:#define IMX412_ID 0x577 This is not a proof the device in question is no IMX412. It's entirely possible Sony has two sensors that both happen to have the same value in the ID register. Quite possibly the sensors, for a reason or another, share the same chip, so also the ID register will be the same. I wouldn't necessarily expect them to make a variant just for that. At least I'd like to see more convincing evidence IMX577 was just confused with IMX412 before merging this. But I'm fine with adding another compatible string for IMX577. -- Regards, Sakari Ailus
