The 07/21/2022 08:46, Krzysztof Kozlowski wrote: > > On 20/07/2022 21:49, Horatiu Vultur wrote: > > Add documentation for Microchip LAN9662 PCB8309. > > > > Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/arm/atmel-at91.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > index 4e495e03264b..9dc9ad81193a 100644 > > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > @@ -169,6 +169,12 @@ properties: > > - const: microchip,lan9662 > > - const: microchip,lan966 > > > > + - description: Microchip LAN9662 PCB8309 Evaluation Board. > > + items: > > + - const: microchip,lan9662-pcb8309 > > This and other lan9662 boards should be just an enum. You grow the file > needlessly... Unless it is clear preference of maintainer. Other boards > follow normal enum approach, so it seems there is no such preference. I can see your point. I will change it in the next version. > > > Best regards, > Krzysztof -- /Horatiu