The 07/21/2022 07:39, Claudiu Beznea - M18063 wrote:
> > +&flx4 {
> > + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
> > + status = "okay";
>
> Embed i2c4 node here as you did for usart3 above. It's easy to follow the
> connection b/w flx node and it's enabled child.
Yes, I will do that.
>
> > +};
> > +
> > +&gpio {
> > + fc3_b_pins: fc3-b-pins {
> > + /* RXD, TXD */
> > + pins = "GPIO_52", "GPIO_53";
> > + function = "fc3_b";
> > + };
> > +
> > + fc4_b_pins: fc4-b-pins {
> > + /* SCL, SDA */
> > + pins = "GPIO_57", "GPIO_58";
> > + function = "fc4_b";
> > + };
> > +
> > + sgpio_a_pins: sgpio-a-pins {
> > + /* SCK, D0, D1, LD */
> > + pins = "GPIO_32", "GPIO_33", "GPIO_34", "GPIO_35";
> > + function = "sgpio_a";
> > + };
> > +};
> > +
> > +&i2c4 {
> > + compatible = "microchip,sam9x60-i2c";
> > + reg = <0x600 0x200>;
> > + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + clocks = <&nic_clk>;
> > + pinctrl-0 = <&fc4_b_pins>;
> > + pinctrl-names = "default";
> > + i2c-analog-filter;
> > + i2c-digital-filter;
> > + i2c-digital-filter-width-ns = <35>;
> > + i2c-sda-hold-time-ns = <1500>;
> > + status = "okay";
> > +};
> > +
> > +&mdio1 {
> > + status = "okay";
> > +};
> > +
> > +&phy0 {
> > + status = "okay";
> > +};
> > +
> > +&phy1 {
> > + status = "okay";
> > +};
> > +
> > +&port0 {
> > + status = "okay";
>
> Keep status at the end of node description for uniformity with the nodes
> enabled above. Same for the rest of nodes below.
OK. I will do that in the next version.
>
> > + phy-handle = <&phy0>;
> > + phy-mode = "gmii";
> > + phys = <&serdes 0 CU(0)>;
> > +};
> > +
> > +&port1 {
> > + status = "okay";
> > + phy-handle = <&phy1>;
> > + phy-mode = "gmii";
> > + phys = <&serdes 1 CU(1)>;
> > +};
> > +
> > +&port2 {
> > + status = "okay";
> > + sfp = <&sfp2>;
> > + managed = "in-band-status";
> > + phy-mode = "sgmii";
> > + phys = <&serdes 2 SERDES6G(0)>;
> > +};
> > +
> > +&port3 {
> > + status = "okay";
> > + sfp = <&sfp3>;
> > + managed = "in-band-status";
> > + phy-mode = "sgmii";
> > + phys = <&serdes 3 SERDES6G(1)>;
> > +};
> > +
> > +&serdes {
> > + status = "okay";
> > +};
> > +
> > +&sgpio {
> > + status = "okay";
> > + pinctrl-0 = <&sgpio_a_pins>;
> > + pinctrl-names = "default";
> > + microchip,sgpio-port-ranges = <0 3>, <8 11>;
>
> Except this one. For this would be nice to have status here before
> describing childs.
OK. I will do that in the next version.
>
> > + gpio@0 {
> > + ngpios = <64>;
> > + };
> > + gpio@1 {
> > + ngpios = <64>;
> > + };
> > +};
> > +
> > +&switch {
> > + status = "okay";
> > +};
>
--
/Horatiu
