Hi Biju, Thanks for the review. On Fri, Jul 22, 2022 at 5:34 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > Thanks for the patch. > > > Subject: [PATCH v2 1/2] dt-bindings: pinctrl: rzg2l-pinctrl: Add macros > > for IRQ0-7 > > > > Add macros for IRQ0-7 which map to SPI1-8 so that it can be used in > > dts/i. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > v1->v2 > > * New patch > > --- > > include/dt-bindings/pinctrl/rzg2l-pinctrl.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/dt-bindings/pinctrl/rzg2l-pinctrl.h b/include/dt- > > bindings/pinctrl/rzg2l-pinctrl.h > > index c78ed5e5efb7..6aae2ac206d6 100644 > > --- a/include/dt-bindings/pinctrl/rzg2l-pinctrl.h > > +++ b/include/dt-bindings/pinctrl/rzg2l-pinctrl.h > > @@ -20,4 +20,14 @@ > > /* Convert a port and pin label to its global pin index */ > > #define RZG2L_GPIO(port, pin) ((port) * RZG2L_PINS_PER_PORT + > > (pin)) > > > > +/* IRQ0-7 map to SPI1-8 */ > > +#define RZG2L_IRQ0 1 > > +#define RZG2L_IRQ1 2 > > +#define RZG2L_IRQ2 3 > > +#define RZG2L_IRQ3 4 > > +#define RZG2L_IRQ4 5 > > +#define RZG2L_IRQ5 6 > > +#define RZG2L_IRQ6 7 > > +#define RZG2L_IRQ7 8 > > + > > Not sure, may be these macros to be moved to [1]?? as it is nothing to do > with rzg2l-pinctrl. > > [1] > include/dt-bindings/interrupt-controller/irqc-rzg2l.h > Agreed, I will move this to irqc-rzg2l.h. > and binding update to use these macros. > Ok. Cheers, Prabhakar
