Re: [PATCH] Add MagicBox M16S support

[Neil Armstrong <narmstrong@xxxxxxxxxxxx>]

On 21/07/2022 16:37, Zhang Ning wrote:
> On Mon, Jul 18, 2022 at 10:02:32AM +0200, Neil Armstrong wrote:
>
> Thank you for review.
> > Hi,
> >
> > On 12/07/2022 16:24, Zhang Ning wrote:
> > > MagicBox M16S or MagicBox 3Pro is popular Tv box in China.
> > >
> > > it's gxm_q201_v1 according u-boot log.
> > > and it's almost same as Q201 reference design.
> > >
> > > add a simple dts to support this Tv box.
> > >
> > > Signed-off-by: Zhang Ning <zhangn1985@xxxxxx>
> > > ---
> > >    arch/arm64/boot/dts/amlogic/Makefile          |  1 +
> > >    .../dts/amlogic/meson-gxm-magicbox-m16s.dts   | 20 +++++++++++++++++++
> > >    2 files changed, 21 insertions(+)
> > >    create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts
> > >
> > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> > > index 8773211df50e..e0907fb41829 100644
> > > --- a/arch/arm64/boot/dts/amlogic/Makefile
> > > +++ b/arch/arm64/boot/dts/amlogic/Makefile
> > > @@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-libretech-cc.dtb
> > >    dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
> > >    dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
> > >    dtb-$(CONFIG_ARCH_MESON) += meson-gxm-khadas-vim2.dtb
> > > +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-magicbox-m16s.dtb
> > >    dtb-$(CONFIG_ARCH_MESON) += meson-gxm-mecool-kiii-pro.dtb
> > >    dtb-$(CONFIG_ARCH_MESON) += meson-gxm-minix-neo-u9h.dtb
> > >    dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb
> > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts
> > > new file mode 100644
> > > index 000000000000..be543d65a529
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts
> > > @@ -0,0 +1,20 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > +/*
> > > + * Copyright (c) 2022 Zhang Ning <zhangn1985@xxxxxx>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "meson-gxm.dtsi"
> > > +#include "meson-gx-p23x-q20x.dtsi"
> > > +#include <dt-bindings/input/input.h>
> > > +#include <dt-bindings/leds/common.h>
> > > +
> > > +/ {
> > > +	compatible = "magicbox,m16s", "amlogic,s912", "amlogic,meson-gxm";
> > > +	model = "MagicBox M16S";
> > > +};
> >
> > The compatible should be documented in the DT bindings in:
> > Documentation/devicetree/bindings/arm/amlogic.yaml
>
> I will update this part next version.
> > > +&ethmac {
> > > +        phy-mode = "rmii";
> > > +        phy-handle = <&internal_phy>;
> > > +};
> >
> > Is the sd_emmc_a change incompatible with the M16S ?
>
> sd_emmc_a is used as SDIO for wifi/bt. and wifi/bt works with this dtb.
> I checked mrvl-sd8997 DT bindings,  missing a lot of properties need
> by mrvl-sd8997.
>
> I don't have schematics to fill these properties, need more time to
> check vendor OS or try each GPIO.

Ok fine no problem, you can push it later when you figure out the properties.

> > Neil

Neil