On 20/07/2022 22:11, nick.hawkins@xxxxxxx wrote:
> From: Nick Hawkins <nick.hawkins@xxxxxxx>
>
> The GXP supports 3 separate SPI interfaces to accommodate the system
> flash, core flash, and other functions. The SPI engine supports variable
> clock frequency, selectable 3-byte or 4-byte addressing and a
> configurable x1, x2, and x4 command/address/data modes. The memory
> buffer for reading and writing ranges between 256 bytes and 8KB. This
> driver supports access to the core flash and bios part.
>
(...)
> +static int gxp_spifi_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + const struct gxp_spi_data *data;
> + struct spi_controller *ctlr;
> + struct gxp_spi *spifi;
> + struct resource *res;
> + int ret;
> +
> + data = of_device_get_match_data(&pdev->dev);
> + if (!data) {
> + dev_err(&pdev->dev, "of_dev_get_match_data failed\n");
Is it even possible to happen? I don't think so, so definitely not worth
log message.
> + return -ENOMEM;
> + }
> +
> + ctlr = devm_spi_alloc_master(dev, sizeof(*spifi));
> + if (!ctlr) {
> + dev_err(&pdev->dev, "spi_alloc_master failed\n");
Aren't you duplicating core messages?
> + return -ENOMEM;
> + }
> +
> + spifi = spi_controller_get_devdata(ctlr);
> + if (!spifi) {
Is it even possible?
> + dev_err(&pdev->dev, "spi_controller_get_data failed\n");
> + return -ENOMEM;
> + }
> +
> + platform_set_drvdata(pdev, spifi);
> + spifi->data = data;
> + spifi->dev = dev;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + spifi->reg_base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(spifi->reg_base))
> + return PTR_ERR(spifi->reg_base);
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> + spifi->dat_base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(spifi->dat_base))
> + return PTR_ERR(spifi->dat_base);
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
> + spifi->dir_base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(spifi->dir_base))
> + return PTR_ERR(spifi->dir_base);
> +
> + ctlr->mode_bits = data->mode_bits;
> + ctlr->bus_num = pdev->id;
> + ctlr->mem_ops = &gxp_spi_mem_ops;
> + ctlr->setup = gxp_spi_setup;
> + ctlr->num_chipselect = data->max_cs;
> + ctlr->dev.of_node = dev->of_node;
> +
> + ret = devm_spi_register_controller(dev, ctlr);
> + if (ret) {
> + dev_err(&pdev->dev, "spi_register_controller failed\n");
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int gxp_spifi_remove(struct platform_device *pdev)
> +{
> + return 0;
> +}
It's empty, why do you need it?
Best regards,
Krzysztof
