On Thu, Jul 21, 2022 at 10:40, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote: > Il 20/07/22 16:48, Mattijs Korpershoek ha scritto: >> MediaTek keypad has 2 modes of detecting key events: >> - single key: each (row, column) can detect one key >> - double key: each (row, column) is a group of 2 keys >> >> Currently, only single key detection is supported (by default) >> Add an optional property, mediatek,double-keys to support double >> key detection. >> >> Double key support exists to minimize cost, since it reduces the number >> of pins required for physical keys. >> >> Signed-off-by: Mattijs Korpershoek <mkorpershoek@xxxxxxxxxxxx> >> >> diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> index ca8ae40a73f7..03c9555849e5 100644 >> --- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> @@ -49,6 +49,12 @@ properties: >> maximum: 256 >> default: 16 >> >> + mediatek,double-keys: >> + description: | >> + use double key matrix instead of single key >> + when set, each (row,column) is a group that can detect 2 keys > > We can make it shorter and (imo) easier to understand, like: > > mediatek,double-keys: > > description: Each (row, column) group has two keys > > ...also because, if we say that the group "can detect" two keys, it may be > creating a misunderstandment such as "if I press one key, it gives me two > different input events for two different keys.", which is something that > wouldn't make a lot of sense, would it? :-) Hi AngeloGioacchino, Thank you for the suggestion. I like your description better as well :) Will use it in v2. > >> + type: boolean >> + >> required: >> - compatible >> - reg
