Hi Li-hao, I love your patch! Yet something to improve: [auto build test ERROR on rafael-pm/thermal] [also build test ERROR on krzk-dt/for-next linus/master v5.19-rc7 next-20220720] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Li-hao-Kuo/Add-thermal-control-driver-for-Sunplus-SoC/20220712-153158 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal config: sh-randconfig-s042-20220715 (https://download.01.org/0day-ci/archive/20220721/202207211145.wLh7TKJt-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/328f3fe3eb3d1984a68c51c4a413821bd4b397b6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Li-hao-Kuo/Add-thermal-control-driver-for-Sunplus-SoC/20220712-153158 git checkout 328f3fe3eb3d1984a68c51c4a413821bd4b397b6 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sh SHELL=/bin/bash .// drivers/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/linux/device.h:15, from include/linux/platform_device.h:13, from drivers/thermal/sunplus_thermal.c:13: drivers/thermal/sunplus_thermal.c: In function 'sunplus_thermal_probe': >> drivers/thermal/sunplus_thermal.c:106:25: error: 'dev' undeclared (first use in this function); did you mean 'pdev'? 106 | dev_err(dev, "Failed to register tsensor: %d\n", ret); | ^~~ include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ drivers/thermal/sunplus_thermal.c:106:17: note: in expansion of macro 'dev_err' 106 | dev_err(dev, "Failed to register tsensor: %d\n", ret); | ^~~~~~~ drivers/thermal/sunplus_thermal.c:106:25: note: each undeclared identifier is reported only once for each function it appears in 106 | dev_err(dev, "Failed to register tsensor: %d\n", ret); | ^~~ include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ drivers/thermal/sunplus_thermal.c:106:17: note: in expansion of macro 'dev_err' 106 | dev_err(dev, "Failed to register tsensor: %d\n", ret); | ^~~~~~~ vim +106 drivers/thermal/sunplus_thermal.c > 13 #include <linux/platform_device.h> 14 #include <linux/reset.h> 15 #include <linux/thermal.h> 16 17 #define ENABLE_THERMAL BIT(31) 18 #define SP_THERMAL_MASK GENMASK(10, 0) 19 20 #define TEMP_RATE 608 21 #define TEMP_BASE 3500 22 #define TEMP_OTP_BASE 1518 23 24 #define SP_THERMAL_CTL0_REG 0x0000 25 #define SP_THERMAL_STS0_REG 0x0030 26 27 /* common data structures */ 28 struct sp_thermal_data { 29 struct thermal_zone_device *pcb_tz; 30 void __iomem *regs; 31 int *otp_temp0; 32 }; 33 34 static int sunplus_get_otp_temp_coef(struct sp_thermal_data *sp_data, struct device *dev) 35 { 36 struct nvmem_cell *cell; 37 ssize_t otp_l; 38 39 cell = nvmem_cell_get(dev, "calib"); 40 if (IS_ERR(cell)) 41 return PTR_ERR(cell); 42 43 sp_data->otp_temp0 = nvmem_cell_read(cell, &otp_l); 44 nvmem_cell_put(cell); 45 46 if (*sp_data->otp_temp0 == 0) 47 *sp_data->otp_temp0 = TEMP_OTP_BASE; 48 49 return 0; 50 } 51 52 /* 53 * There is a thermal sensor instance for Sunplus Soc 54 * T_CODE is the ADC of the thermal sensor 55 * T_CODE : 11 digits in total 56 * When remanufacturing, the 35 degree T_CODE will be read and stored in nvcell. 57 * otp_temp0 is the 35 degree T_CODE obtained from nvcell 58 * The function will get 35 degree T_CODE for thermal calibration. 59 * TEMP_RATE is the Sunplus thermal temperature slope. 60 */ 61 62 static int sp_thermal_get_sensor_temp(void *data, int *temp) 63 { 64 struct sp_thermal_data *sp_data = data; 65 int t_code; 66 67 t_code = readl(sp_data->regs + SP_THERMAL_STS0_REG); 68 t_code = FIELD_GET(SP_THERMAL_MASK, t_code); 69 *temp = ((*sp_data->otp_temp0 - t_code) * 10000 / TEMP_RATE) + TEMP_BASE; 70 *temp *= 10; 71 return 0; 72 } 73 74 static const struct thermal_zone_of_device_ops sp_of_thermal_ops = { 75 .get_temp = sp_thermal_get_sensor_temp, 76 }; 77 78 static int sunplus_thermal_probe(struct platform_device *pdev) 79 { 80 struct sp_thermal_data *sp_data; 81 int ret; 82 83 sp_data = devm_kzalloc(&pdev->dev, sizeof(*sp_data), GFP_KERNEL); 84 if (!sp_data) 85 return -ENOMEM; 86 87 sp_data->regs = devm_platform_ioremap_resource(pdev, 0); 88 if (IS_ERR(sp_data->regs)) { 89 dev_err(&pdev->dev, "resource get fail\n"); 90 return PTR_ERR(sp_data->regs); 91 } 92 93 writel(ENABLE_THERMAL, sp_data->regs + SP_THERMAL_CTL0_REG); 94 95 platform_set_drvdata(pdev, sp_data); 96 ret = sunplus_get_otp_temp_coef(sp_data, &pdev->dev); 97 if (ret) 98 return ret; 99 100 sp_data->pcb_tz = devm_thermal_zone_of_sensor_register(&pdev->dev, 101 0, 102 sp_data, &sp_of_thermal_ops); 103 104 if (IS_ERR(sp_data->pcb_tz)) { 105 ret = PTR_ERR(sp_data->pcb_tz); > 106 dev_err(dev, "Failed to register tsensor: %d\n", ret); 107 return ret; 108 } 109 110 return ret; 111 } 112 -- 0-DAY CI Kernel Test Service https://01.org/lkp
