Re: [PATCH 1/2] of: Don't try to search when phandle == 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Oops. This is a standalone patch. Please ignore the [1/2] in the header.

g.

On Thu, Oct 2, 2014 at 1:12 PM, Grant Likely <grant.likely@xxxxxxxxxx> wrote:
> A value of '0' isn't a valid phandle, so searching for a node with that
> phandle is pointless. It will result in nothing but false positives.
>
> Signed-off-by: Grant Likely <grant.likely@xxxxxxxxxx>
> ---
>  drivers/of/base.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 293ed4b687ba..2305dc0382bc 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -1021,6 +1021,9 @@ struct device_node *of_find_node_by_phandle(phandle handle)
>         struct device_node *np;
>         unsigned long flags;
>
> +       if (!handle)
> +               return NULL;
> +
>         raw_spin_lock_irqsave(&devtree_lock, flags);
>         for (np = of_allnodes; np; np = np->allnext)
>                 if (np->phandle == handle)
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux