Hi Rob, Please see my reply. -----Original Message----- From: Rob Herring <robh@xxxxxxxxxx> Sent: Wednesday, July 13, 2022 10:52 PM To: Raphael-Xu <13691752556@xxxxxxx> Cc: alsa-devel@xxxxxxxxxxxxxxxx; Xu, Yang <raphael-xu@xxxxxx>; Ding, Shenghao <shenghao-ding@xxxxxx>; Navada Kanyana, Mukund <navada@xxxxxx>; Syrus, Andy <asyrus@xxxxxx>; broonie@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx Subject: [EXTERNAL] Re: [PATCH v5] update tas2780.yaml On Tue, Jul 12, 2022 at 01:08:57PM +0800, Raphael-Xu wrote: > 1.remove unused item in DT 2.revise the format Again, fix your subject. Run 'git log --oneline Documentation/devicetree/bindings/sound/' for inspiration of the format of the subject. [RX]:just submit new patch However, there's a bigger issue here. We already have a binding for this device. It's in tas27xx.yaml. And you added 2780 to it, so why did you add another schema? (All the same issues in that patch too. wrong subject, broken schema. So you haven't learned.) [RX]:We will follow tas2780 patch format and submit separate patch if you think tas2780 patch is acceptable. And then there is also tas2770.yaml which appears to be about the same as well. [RX]:We will follow tas2780 patch format and submit separate patch if you think tas2780 patch is acceptable. > > Signed-off-by: Raphael-Xu <13691752556@xxxxxxx> > --- > .../devicetree/bindings/sound/tas2780.yaml | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-)
