RE: [PATCH V3 4/7] soc: imx: add i.MX8MP HDMI blk ctrl HDCP/HRV

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Subject: Re: [PATCH V3 4/7] soc: imx: add i.MX8MP HDMI blk ctrl HDCP/HRV
> 
> Hi "Peng,
[Peng Fan] 

As I wrote in cover-letter, this patch depends on the other patchset, so
it is expected if directly build this patchset.

Regards,
Peng.

> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on shawnguo/for-next] [also build test WARNING
> on linus/master v5.19-rc7 next-20220719] [cannot apply to robh/for-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit-
> scm.com%2Fdocs%2Fgit-format-
> patch%23_base_tree_information&data=05%7C01%7Cpeng.fan%40nx
> p.com%7C10c48f8d87c4495ae2cb08da699c4cf9%7C686ea1d3bc2b4c6fa92c
> d99c5c301635%7C0%7C0%7C637938417271437135%7CUnknown%7CTWFp
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C3000%7C%7C%7C&sdata=j52hhniJ9%2F8Erb1s%2BWs
> Tbrt6PrEFUNFx%2FOpuaVliIk8%3D&reserved=0]
> 
> url:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fintel-lab-lkp%2Flinux%2Fcommits%2FPeng-Fan-OSS%2Fimx-add-i-
> MX8MP-hdmi-blk-ctrl-hdcp-hrv-and-vpu-blk-ctrl%2F20220719-
> 135352&data=05%7C01%7Cpeng.fan%40nxp.com%7C10c48f8d87c449
> 5ae2cb08da699c4cf9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> 7C637938417271437135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7
> C%7C&sdata=B1ZT%2B01n%2FntH1CuS6diMTiwYT6F%2FWcWa2wN%2
> BCI07oaA%3D&reserved=0
> base:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ke
> rnel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fshawnguo%2Flinux.git
> &data=05%7C01%7Cpeng.fan%40nxp.com%7C10c48f8d87c4495ae2cb0
> 8da699c4cf9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63793
> 8417271437135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&a
> mp;sdata=rT48ZhcxCPw5jkaxziGZIkZeGhOsfNMmHwTy79hpxHw%3D&r
> eserved=0 for-next
> config: microblaze-allmodconfig
> (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdow
> nload.01.org%2F0day-
> ci%2Farchive%2F20220719%2F202207192320.p1W4jEjD-
> lkp%40intel.com%2Fconfig&data=05%7C01%7Cpeng.fan%40nxp.com%
> 7C10c48f8d87c4495ae2cb08da699c4cf9%7C686ea1d3bc2b4c6fa92cd99c5c3
> 01635%7C0%7C0%7C637938417271437135%7CUnknown%7CTWFpbGZsb3d
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%
> 3D%7C3000%7C%7C%7C&sdata=sZzZ%2Fhe0aDQ0hhNOkNEyURDlzYP1
> F4xjkRey4lzZBLI%3D&reserved=0)
> compiler: microblaze-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build):
>         wget
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.
> githubusercontent.com%2Fintel%2Flkp-
> tests%2Fmaster%2Fsbin%2Fmake.cross&data=05%7C01%7Cpeng.fan%
> 40nxp.com%7C10c48f8d87c4495ae2cb08da699c4cf9%7C686ea1d3bc2b4c6f
> a92cd99c5c301635%7C0%7C0%7C637938417271437135%7CUnknown%7CT
> WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tO6jPASKjlJjMPM12kf7
> MeyVbK3%2BfnjRxjfaumbGPE8%3D&reserved=0 -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         #
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fintel-lab-
> lkp%2Flinux%2Fcommit%2F328924f29e2ab1b6667c1be9578a9e17a7824c71
> &data=05%7C01%7Cpeng.fan%40nxp.com%7C10c48f8d87c4495ae2cb0
> 8da699c4cf9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63793
> 8417271437135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&a
> mp;sdata=otOy63cAD8a6%2BGdQBEA0E4GiFw%2BtrUCM7JH5lGh4mbs%3D
> &reserved=0
>         git remote add linux-review
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fintel-lab-
> lkp%2Flinux&data=05%7C01%7Cpeng.fan%40nxp.com%7C10c48f8d87c
> 4495ae2cb08da699c4cf9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C637938417271437135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w
> LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%7C&sdata=E65GHnHqVvRXXZTqnFGTbpXudJCL7uVZQ41zcQvsCPE
> %3D&reserved=0
>         git fetch --no-tags linux-review Peng-Fan-OSS/imx-add-i-MX8MP-hdmi-
> blk-ctrl-hdcp-hrv-and-vpu-blk-ctrl/20220719-135352
>         git checkout 328924f29e2ab1b6667c1be9578a9e17a7824c71
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0
> make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash
> drivers/soc/imx/ sound/soc/sof/imx/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/soc/imx/imx8mp-blk-ctrl.c:375:18: error: 'const struct
> imx8mp_blk_ctrl_domain_data' has no member named 'path_names'
>      375 |                 .path_names = (const char *[]){"hrv"},
>          |                  ^~~~~~~~~~
> >> drivers/soc/imx/imx8mp-blk-ctrl.c:375:31: warning: excess elements in
> >> struct initializer
>      375 |                 .path_names = (const char *[]){"hrv"},
>          |                               ^
>    drivers/soc/imx/imx8mp-blk-ctrl.c:375:31: note: (near initialization for
> 'imx8mp_hdmi_domain_data[8]')
>    drivers/soc/imx/imx8mp-blk-ctrl.c:376:18: error: 'const struct
> imx8mp_blk_ctrl_domain_data' has no member named 'num_paths'
>      376 |                 .num_paths = 1,
>          |                  ^~~~~~~~~
>    drivers/soc/imx/imx8mp-blk-ctrl.c:376:30: warning: excess elements in
> struct initializer
>      376 |                 .num_paths = 1,
>          |                              ^
>    drivers/soc/imx/imx8mp-blk-ctrl.c:376:30: note: (near initialization for
> 'imx8mp_hdmi_domain_data[8]')
>    drivers/soc/imx/imx8mp-blk-ctrl.c:383:18: error: 'const struct
> imx8mp_blk_ctrl_domain_data' has no member named 'path_names'
>      383 |                 .path_names = (const char *[]){"hdcp"},
>          |                  ^~~~~~~~~~
>    drivers/soc/imx/imx8mp-blk-ctrl.c:383:31: warning: excess elements in
> struct initializer
>      383 |                 .path_names = (const char *[]){"hdcp"},
>          |                               ^
>    drivers/soc/imx/imx8mp-blk-ctrl.c:383:31: note: (near initialization for
> 'imx8mp_hdmi_domain_data[7]')
>    drivers/soc/imx/imx8mp-blk-ctrl.c:384:18: error: 'const struct
> imx8mp_blk_ctrl_domain_data' has no member named 'num_paths'
>      384 |                 .num_paths = 1,
>          |                  ^~~~~~~~~
>    drivers/soc/imx/imx8mp-blk-ctrl.c:384:30: warning: excess elements in
> struct initializer
>      384 |                 .num_paths = 1,
>          |                              ^
>    drivers/soc/imx/imx8mp-blk-ctrl.c:384:30: note: (near initialization for
> 'imx8mp_hdmi_domain_data[7]')
> 
> 
> vim +375 drivers/soc/imx/imx8mp-blk-ctrl.c
> 
>    326
>    327	static const struct imx8mp_blk_ctrl_domain_data
> imx8mp_hdmi_domain_data[] = {
>    328		[IMX8MP_HDMIBLK_PD_IRQSTEER] = {
>    329			.name = "hdmiblk-irqsteer",
>    330			.clk_names = (const char *[]){ "apb" },
>    331			.num_clks = 1,
>    332			.gpc_name = "irqsteer",
>    333		},
>    334		[IMX8MP_HDMIBLK_PD_LCDIF] = {
>    335			.name = "hdmiblk-lcdif",
>    336			.clk_names = (const char *[]){ "axi", "apb" },
>    337			.num_clks = 2,
>    338			.gpc_name = "lcdif",
>    339		},
>    340		[IMX8MP_HDMIBLK_PD_PAI] = {
>    341			.name = "hdmiblk-pai",
>    342			.clk_names = (const char *[]){ "apb" },
>    343			.num_clks = 1,
>    344			.gpc_name = "pai",
>    345		},
>    346		[IMX8MP_HDMIBLK_PD_PVI] = {
>    347			.name = "hdmiblk-pvi",
>    348			.clk_names = (const char *[]){ "apb" },
>    349			.num_clks = 1,
>    350			.gpc_name = "pvi",
>    351		},
>    352		[IMX8MP_HDMIBLK_PD_TRNG] = {
>    353			.name = "hdmiblk-trng",
>    354			.clk_names = (const char *[]){ "apb" },
>    355			.num_clks = 1,
>    356			.gpc_name = "trng",
>    357		},
>    358		[IMX8MP_HDMIBLK_PD_HDMI_TX] = {
>    359			.name = "hdmiblk-hdmi-tx",
>    360			.clk_names = (const char *[]){ "apb", "ref_266m" },
>    361			.num_clks = 2,
>    362			.gpc_name = "hdmi-tx",
>    363		},
>    364		[IMX8MP_HDMIBLK_PD_HDMI_TX_PHY] = {
>    365			.name = "hdmiblk-hdmi-tx-phy",
>    366			.clk_names = (const char *[]){ "apb", "ref_24m" },
>    367			.num_clks = 2,
>    368			.gpc_name = "hdmi-tx-phy",
>    369		},
>    370		[IMX8MP_HDMIBLK_PD_HRV] = {
>    371			.name = "hdmiblk-hrv",
>    372			.clk_names = (const char *[]){ "axi", "apb" },
>    373			.num_clks = 2,
>    374			.gpc_name = "hrv",
>  > 375			.path_names = (const char *[]){"hrv"},
>    376			.num_paths = 1,
>    377		},
>    378		[IMX8MP_HDMIBLK_PD_HDCP] = {
>    379			.name = "hdmiblk-hdcp",
>    380			.clk_names = (const char *[]){ "axi", "apb" },
>    381			.num_clks = 2,
>    382			.gpc_name = "hdcp",
>    383			.path_names = (const char *[]){"hdcp"},
>    384			.num_paths = 1,
>    385		},
>    386	};
>    387
> 
> --
> 0-DAY CI Kernel Test Service
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F01.or
> g%2Flkp&amp;data=05%7C01%7Cpeng.fan%40nxp.com%7C10c48f8d87c449
> 5ae2cb08da699c4cf9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> 7C637938417271437135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7
> C%7C&amp;sdata=IAl%2FXvFsNel91HfuahEWK%2BMJWkYJHGs76AXN7cvXx
> Eo%3D&amp;reserved=0




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux