> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Tuesday, July 19, 2022 3:14 PM > To: Shenwei Wang <shenwei.wang@xxxxxxx>; Rob Herring > <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; > Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Pengutronix Kernel Team > <kernel@xxxxxxxxxxxxxx>; Peng Fan <peng.fan@xxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [EXT] Re: [PATCH RESEND v3 3/3] arm64: dts: imx: add imx8dxl > support > > Caution: EXT Email > > On 19/07/2022 21:28, Shenwei Wang wrote: > >>>> > >>>> Didn't you ignore (again) comments? > >>> > >>> The SoC requires two Crystal clock inputs, one is 24MHz and the other is > 32KHz. > >> The board design doesn't have an option to change the values. That's > >> why we keep the nodes here. > >> > >> It's the same everywhere, nothing new here. Where is the clock? On the > board. > >> Not in the Soc. For convenience clock could be here, but at least the > >> frequency by convention is put to the board. > > > > It is a little different here. Although the XTAL itself is on the board, a user has > no choice here to select the clock frequency. It must use the 24MHz and 32KHz > XTALs, and the two frequencies can't be changed. This is the mandatory > requirement. > > I understand, it's the same on many other boards. Still the clock is not part of > SoC design. It is always on the board. iMX is not special here, so why would you > expect here an exception? Actually you cannot simply say that the clock is not part of SoC design, but this is not important. As long as it is a reasonable and consistent rule, we just follow it. However, it seems the rule is changing again here? This is just following what the current upstreaming implementation does like iMX8QXP, iMX8MM, ... etc. Are you taking iMX8DXL as a special one? Or are we going to change all the current implementations to follow this rule? Thanks, Shenwei > > > Best regards, > Krzysztof
