Re: [PATCH 2/3] ARM: dts: lan966x: Disable can0 on pcb8291

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The 07/19/2022 07:55, Claudiu Beznea - M18063 wrote:
> On 19.07.2022 00:29, Horatiu Vultur wrote:
> > On pcb8291, can0 and the network driver share some of the GPIOs so only
> > 1 device can be active. Therefore disable can0 as we want to enable the
> > network driver.
> > 
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/lan966x-pcb8291.dts | 12 ------------
> >  1 file changed, 12 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > index 02fbf7371a8d..2cb532aa33f0 100644
> > --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> > +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > @@ -30,18 +30,6 @@ fc3_b_pins: fc3-b-pins {
> >  		pins = "GPIO_52", "GPIO_53";
> >  		function = "fc3_b";
> >  	};
> > -
> > -	can0_b_pins:  can0-b-pins {
> > -		/* RX, TX */
> > -		pins = "GPIO_35", "GPIO_36";
> > -		function = "can0_b";
> > -	};
> > -};
> > -
> > -&can0 {
> > -	pinctrl-0 = <&can0_b_pins>;
> > -	pinctrl-names = "default";
> > -	status = "okay";
> 
> You can just delete the status line here or change it to "disabled" and
> leave the rest for reference. For evaluation one could just enable it here
> afterwards. On the other AT91 specific boards we are using status =
> "disabled"; and a short comment after like this:
> 
> 	status = "disabled"; /* Conflict with gmac0. */

That is a great idea. Yes I will do that.

> 
> >  };
> >  
> >  &flx3 {
> 

-- 
/Horatiu



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux