Re: [PATCH] dt-bindings: leds: class-multicolor: reference class directly in multi-led node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/07/2022 17:22, Rob Herring wrote:
> On Fri, Jun 24, 2022 at 5:21 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> The leds/common.yaml is referenced directly in each LED node, which
>> leads to people doing the same with leds/leds-class-multicolor.yaml.
>> This is not correct because leds-class-multicolor.yaml defined multi-led
>> property and its children.  Some schemas implemented this incorrect.
>>
>> Rework this to match same behavior common.yaml, so expect the multi-led
>> node to reference the leds-class-multicolor.yaml.  Fixing allows to add
>> unevaluatedProperties:false.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> ---
>>
>> This will conflict with any new users of leds-class-multicolor, e.g.:
>> https://lore.kernel.org/all/20220623115631.22209-4-peterwu.pub@xxxxxxxxx/
>>
>> The new users should be updated to match the usage introduced here.
>> ---
>>  .../leds/cznic,turris-omnia-leds.yaml         |  2 ++
>>  .../bindings/leds/leds-class-multicolor.yaml  | 32 +++++++++----------
>>  .../devicetree/bindings/leds/leds-lp50xx.yaml |  2 ++
>>  .../bindings/leds/leds-pwm-multicolor.yaml    |  5 ++-
>>  .../bindings/leds/leds-qcom-lpg.yaml          |  2 ++
>>  5 files changed, 24 insertions(+), 19 deletions(-)
> 
> Looks like this introduced a new warning:
> 

I'll fix it.


Best regards,
Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux